Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heading #1537

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix heading #1537

merged 2 commits into from
Sep 3, 2024

Conversation

martincostello
Copy link
Contributor

Pull request description

Fix heading not rendering correctly.

Separately the sentence doesn’t seem right, like something was accidentally deleted, but I’m not sure what it was. I can tweak that too if needed if you let me know what it is.

PR meta checklist

  • Pull request is targeted at main branch for code
    or targeted at stable branch for documentation that is live on bunit.dev.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@martincostello
Fix heading
218e91a 
Fix heading not rendering correctly.
@martincostello
Copy link
Contributor Author

I still need to fix this properly. I realise now the text is part of the heading, but it's the heading itself is broken for some reason. I'll need to do that when I'm back at my laptop with a decent Markdown editor.

@linkdotnet
Copy link
Collaborator

linkdotnet commented Sep 3, 2024 •
edited
Loading

Hey @martincostello

Thanks for pointing that out. The simple fix is the wrong whitespace between ## and the title. The reason is: Me :D
On mac if you use Option+Space it does something like a whitespace, but it isn't printable via Markdown.

Anyway - the fix belongs to you ;)

image

@martincostello
Fix heading
3278d51 
Be gone, crazy space.
@martincostello martincostello marked this pull request as ready for review September 3, 2024 18:56
@martincostello
Copy link
Contributor Author

Thanks - that would have taken me ages to puzzle out 😆

@linkdotnet
Copy link
Collaborator

LGTM and big thanks @martincostello !
As soon as the CI pipeline says: 👍 I will merge it.

@linkdotnet
Copy link
Collaborator

Thanks - that would have taken me ages to puzzle out 😆

Imagine the first time I stumbled across this "feature" :D

@linkdotnet linkdotnet enabled auto-merge (squash) September 3, 2024 19:04
@linkdotnet
Copy link
Collaborator

@egil Disabling the "ghost" workflows didn't help, unfortunately.
By the power of Greyskull: Can you force-merge?

@egil egil disabled auto-merge September 3, 2024 19:49
@egil egil merged commit 11696fa into bUnit-dev:stable Sep 3, 2024
10 checks passed
@martincostello martincostello deleted the patch-3 branch September 3, 2024 20:02
egil pushed a commit that referenced this pull request Sep 3, 2024
@martincostello @egil
docs: Fix heading (#1537)
3d03d6f 
* Fix heading

Fix heading not rendering correctly.

* Fix heading

Be gone, crazy space.
linkdotnet added a commit that referenced this pull request Sep 4, 2024
@bUnitBot @martincostello @linkdotnet
Update main with documentation in stable (#1541)
f022007 
* docs: Fix heading (#1537)

* Fix heading

Fix heading not rendering correctly.

* Fix heading

Be gone, crazy space.

* docs: Fix AddFakePersistentComponentState examples (Fixes #1539) (#1540)

---------

Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Steven Giesel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkdotnet linkdotnet linkdotnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martincostello @linkdotnet @egil